Skip to content

Allow wildcard patterns in GroupID column values#367

Merged
rrivera747 merged 9 commits intodevelopfrom
copilot/allow-wildcard-in-groupid-names
Mar 11, 2026
Merged

Allow wildcard patterns in GroupID column values#367
rrivera747 merged 9 commits intodevelopfrom
copilot/allow-wildcard-in-groupid-names

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026 •
edited
Loading

  • Replace exact string comparisons in TableView::isEntryInGroupCol with StringMacros::wildCardMatch to support wildcard patterns (e.g., <group>-*) in GroupID column values
  • Verify StringMacros.h is already included in TableView.cc (confirmed at line 2)
  • Argument order verified: stored cell value (may contain wildcards) is the pattern (first arg), groupNeedle (specific group being searched) is the test string (second arg) — consistent with inWildCardSet convention
  • Fix: use exact match when groupIDList != nullptr (called by removeRowFromGroup to build group list), and wildcard only when groupIDList == nullptr (pure membership check)
  • Restore __COUTS__(2) debug logging in getGroupRowsInVectors loop (COUTS(2) is lower severity than COUT and not printed normally)
  • Restore __COUTT__ trace logging in isEntryInGroupCol; fix quoting bug in "is in group" message ("!'" → "'!")
  • Remove noisy unconditional __COUTT__ from StringMacros::wildCardMatch (widely-used utility)
Original prompt

This section details on the original issue you should resolve

<issue_title>Allow wildcard in GroupID names when sharing rows in tables between many groups</issue_title>
<issue_description>This would allow table rows like:

 <group>-*

instead of:

 <group>-01 | <group>-02 | ... | <group>-N
```</issue_description>

<agent_instructions>Allow group id matching with the * wildcard. Leverage the Wildcard matching in StringMacros::</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@rrivera747
Allow wildcard in GroupID names when sharing rows between many groups
73f04f1 
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Copilot AI changed the title [WIP] Allow wildcard in GroupID names for row sharing Allow wildcard patterns in GroupID column values Mar 9, 2026
@rrivera747
Copy link
Contributor

rrivera747 commented Mar 11, 2026 •
edited
Loading

GroupID matching previously supported only * to match all before. Now * wildcard can be anywhere in the Group ID string of the child.

@rrivera747 rrivera747 marked this pull request as ready for review March 11, 2026 15:22
@rrivera747 rrivera747 requested a review from Copilot March 11, 2026 15:23
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds wildcard (*) support for matching GroupID column values so rows can be shared across many groups without enumerating each exact group name.

Changes:

  • Updated TableView::isEntryInGroupCol to use StringMacros::wildCardMatch(storedPattern, groupNeedle) instead of exact ==.
  • Expanded StringMacros::wildCardMatch to support * anywhere in the pattern (not just leading/trailing).
  • Introduced additional trace/debug logging in group row selection and wildcard matching paths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
otsdaq/TableCore/TableView.cc Uses wildcard matching for GroupID membership checks; adds verbose debug/trace logging in group filtering and token parsing.
otsdaq/Macros/StringMacros.cc Extends wildcard matching implementation to handle internal *; adds trace logging inside the matcher.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rrivera747
Fix wildcard matching: use exact match when groupIDList is requested,…
e2f437c 
… wildcard only for membership checks; remove noisy debug logging

Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
@rrivera747
Restore debug logging; fix trace message quoting in isEntryInGroupCol
004a269 
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
rrivera747
rrivera747 approved these changes Mar 11, 2026
View reviewed changes
Copy link
Contributor

@rrivera747 rrivera747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rrivera747 rrivera747 requested a review from eflumerf March 11, 2026 17:29
@rrivera747 rrivera747 merged commit 328dffd into develop Mar 11, 2026
11 checks passed
@rrivera747 rrivera747 deleted the copilot/allow-wildcard-in-groupid-names branch March 11, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@eflumerf eflumerf eflumerf approved these changes

+1 more reviewer

@rrivera747 rrivera747 rrivera747 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rrivera747 rrivera747

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow wildcard in GroupID names when sharing rows in tables between many groups

4 participants

@rrivera747 @eflumerf